Changeset 6654 for trunk/ARBDB/adstring.cxx

Timestamp:

13/05/10 17:30:03 (2 years ago)

Author:

westram

Message:

• This patch stuffs all memory leaks in ARBDB (as far as covered by unit-tests) for DEBUG and NDEBUG version!
• ARBDB global data (aka 'gb_local')
  • track number of opened/closed DBs
  • GBK_install_SIGSEGV_handler only once in GB_init_gb()
  • when closing last DB -> call GB_exit_gb() freeing more memory (also called atexit, including assertion failing if a DB is still open)
  • added class ARBDB_memory_manager (just calls gbm_init_mem + gbm_flush_mem)
  • GB_exit_gb flushes ARBDB_memory_manager (if all blocks were freed by gbm_free_mem, everything will be flushed)
• fixed a few more static buffer leaks
• gb_make_entry - alloc correct blocksizes for GB_STRING and GB_LINK
• fixed a hack in gb_read_bin_rek_V2
  • was increasing size of memory block to avoid illegal memory access in decompress (introduced in [1003]; may occur again)
  • due to mismatch in size between gbm_get_mem and gbm_free_mem memory was never flushed even if all blocks have been freed
• fixed memleak in gb_read_bin_rek_V2
  • when loading mapfile, previously created 'gb_main' was not freed
• added allocation logger to admalloc.cxx (inactive - use TRACE_ALLOCS to activate it)
  • traces all allocs/frees of ARBDB managed memory
  • detects wrong usage (double free, size and index mismatch) and shows were the block was allocated
  • added new backtrace functions helpful for debugging (store stack-backtraces and print them later)

Files:

• trunk/ARBDB/adstring.cxx (modified) (2 diffs)

trunk/ARBDB/adstring.cxx

@@ -167 +167 @@
 GB_ERROR GB_await_error() {
     if (GB_error_buffer) {
-        static char *err = 0;
-        reassign(err, GB_error_buffer);
-        return err;
+        static SmartMallocPtr(char) err;
+        err             = GB_error_buffer;
+        GB_error_buffer = NULL;
+        return &*err;
     }
     gb_assert(0);               // please correct error handling
@@ -1113 +1114 @@
 #define MAX_BACKTRACE 66
 
-void GBK_dump_backtrace(FILE *out, GB_ERROR error) {
-    void   *array[MAX_BACKTRACE];
-    size_t  size = backtrace(array, MAX_BACKTRACE); // get void*'s for all entries on the stack
-
-    if (!out) out = stderr;
-
-    // print out all the frames to out
-    fprintf(out, "\n-------------------- ARB-backtrace for '%s':\n", error);
-    backtrace_symbols_fd(array, size, fileno(out));
-    if (size == MAX_BACKTRACE) fputs("[stack truncated to avoid deadlock]\n", out);
-    fputs("-------------------- End of backtrace\n", out);
-    fflush(out);
+class BackTraceInfo {
+    void   **array;
+    size_t  size;
+public:
+    BackTraceInfo(size_t skipFramesAtBottom) {
+        void *tmp[MAX_BACKTRACE];
+        size = backtrace(tmp, MAX_BACKTRACE);
+
+        size_t ssize = skipFramesAtBottom*sizeof(*array);
+        size_t msize = size*sizeof(*array) - ssize;
+
+        gb_assert(msize>0);
+        
+        array = (void**)malloc(msize);
+        memcpy(array, tmp+skipFramesAtBottom, msize);
+    }
+    ~BackTraceInfo() { free(array); }
+
+    void dump(FILE *out, GB_CSTR message) {
+        // print out all the frames to out
+        fprintf(out, "\n-------------------- ARB-backtrace '%s':\n", message);
+        backtrace_symbols_fd(array, size, fileno(out));
+        if (size == MAX_BACKTRACE) fputs("[stack truncated to avoid deadlock]\n", out);
+        fputs("-------------------- End of backtrace\n", out);
+        fflush(out);
+    }
+};
+
+class BackTraceInfo *GBK_get_backtrace(size_t skipFramesAtBottom) {
+    return new BackTraceInfo(skipFramesAtBottom);
+}
+void GBK_dump_former_backtrace(class BackTraceInfo *trace, FILE *out, GB_CSTR message) {
+    trace->dump(out, message);
+}
+void GBK_free_backtrace(class BackTraceInfo *trace) {
+    delete trace;
+}
+
+void GBK_dump_backtrace(FILE *out, GB_CSTR message) {
+    BackTraceInfo trace(0);
+    trace.dump(out ? out : stderr, message);
 }