Changeset 8300

Timestamp:

12/12/11 15:52:22 (6 months ago)

Author:

westram

Message:

• cppchecked (1.52)

Location:

trunk

Files:

• AISC_COM/AISC/aisc_global.pa (modified) (1 diff)
• AISC_COM/C/server.c (modified) (1 diff)
• ARB_GDE/GDE_FileIO.cxx (modified) (1 diff)
• AWT/AWT_config_manager.cxx (modified) (1 diff)
• AWT/AWT_input_mask.cxx (modified) (1 diff)
• EDIT4/ED4_secedit.cxx (modified) (1 diff)
• PARSIMONY/GA_window.cxx (modified) (1 diff)
• PGT/image_dialog.cxx (modified) (1 diff)
• PGT/plot.cxx (modified) (1 diff)
• WINDOW/AW_device.cxx (modified) (1 diff)
• WINDOW/AW_window.cxx (modified) (1 diff)

trunk/AISC_COM/AISC/aisc_global.pa

@@ -25 +25 @@
 P  * ----------------------------------------------------------------- */
 --
-P #include "aisc_server.h"
+P #include <aisc_server.h>
 --
 

trunk/AISC_COM/C/server.c

@@ -27 +27 @@
 #include <setjmp.h>
 
-#include "aisc_com.h"
+#include <aisc_com.h>
 // AISC_MKPT_PROMOTE:#include <aisc_func_types.h>
 #include <attributes.h>

trunk/ARB_GDE/GDE_FileIO.cxx

@@ -1 +1 @@
 #include "GDE_proto.h"
-#include "limits.h"
+#include <limits.h>
 #include <aw_msg.hxx>
 

trunk/AWT/AWT_config_manager.cxx

@@ -358 +358 @@
     config_map::iterator begin() { return cmap.begin(); }
     config_map::const_iterator end() const { return cmap.end(); }
-    // cppcheck-suppress functionConst
     config_map::iterator end() { return cmap.end(); }
 };

trunk/AWT/AWT_input_mask.cxx

@@ -2061 +2061 @@
     free(title);
 }
-// cppcheck-suppress publicAllocationError
+
 awt_input_mask_descriptor::awt_input_mask_descriptor(const awt_input_mask_descriptor& other) {
     title             = strdup(other.title);

trunk/EDIT4/ED4_secedit.cxx

@@ -9 +9 @@
 // =============================================================== //
 
-#include "ed4_secedit.hxx"
+#include <ed4_secedit.hxx>
 
 #include <secedit_extern.hxx>

trunk/PARSIMONY/GA_window.cxx

@@ -15 +15 @@
 #include "ap_tree_nlen.hxx"
 #include "GA_genetic.hxx"
-#include "phwin.hxx"
+#include <phwin.hxx>
 #include <ntcanvas.hxx>
 

trunk/PGT/image_dialog.cxx

@@ -15 +15 @@
 #include "config_dialog.hxx"
 #include "help_dialog.hxx"
-#include "math.h"
+#include <math.h>
 #include <X11/cursorfont.h>
 

trunk/PGT/plot.cxx

@@ -170 +170 @@
 
     // CREATE A TEMPORARY FILENAME (USING MKSTEMP)
-    m_temp_name= (char *)malloc(17 * sizeof(char));
+    m_temp_name = (char *)malloc(17 * sizeof(char));
     strcpy(m_temp_name, "/tmp/plot_XXXXXX");
-        if((mkstemp(m_temp_name)) == -1) return NULL;
-
-    // AS MKTEMP ALSO CREATES THE FILE ITSELF (WHAT WE DON'T WANT) REMOVE IT
-    // RIGHT AFTER ITS CREATION FOR FURTHER USE AS A PIPE
-    unlink(m_temp_name);
-
-    // CREATE A FIFO PIPE
-    if(mkfifo(m_temp_name, S_IRUSR | S_IWUSR) != 0) return NULL;
-    m_command_pipe= popen(buf, "w");
-
-    m_has_command_pipe= true;
+
+    FILE *result = NULL;
+    if ((mkstemp(m_temp_name)) != -1) {
+        // AS MKTEMP ALSO CREATES THE FILE ITSELF (WHAT WE DON'T WANT) REMOVE IT
+        // RIGHT AFTER ITS CREATION FOR FURTHER USE AS A PIPE
+        unlink(m_temp_name);
+
+        // CREATE A FIFO PIPE
+        if (mkfifo(m_temp_name, S_IRUSR | S_IWUSR) == 0) {
+            m_command_pipe     = popen(buf, "w");
+            m_has_command_pipe = true;
+            result             = m_command_pipe;
+        }
+    }
 
     free(buf);
-
-    return m_command_pipe;
+    return result;
 }
 

trunk/WINDOW/AW_device.cxx

@@ -388 +388 @@
 #endif // DEBUG
 
-// cppcheck-suppress noConstructor
 class AW_clip_scale_stack {
     // completely private, but accessible by AW_device

trunk/WINDOW/AW_window.cxx

@@ -1200 +1200 @@
 }
 
-// cppcheck-suppress publicAllocationError
 void AW_area_management::set_double_click_callback(AW_window *aww, void (*f)(AW_window*, AW_CL, AW_CL), AW_CL cd1, AW_CL cd2) {
     double_click_cb = new AW_cb_struct(aww, f, cd1, cd2, (char*)0, double_click_cb);