Opened 13 years ago

Closed 9 years ago

#243 closed task (wontfix)

Dynamically adjust MATCH_MAX_HITS default

Reported by: epruesse Owned by: devel
Priority: normal Milestone:
Component: PT server Version: SVN
Keywords: Cc:

Description

The PT server counts the number of species anyway. The maximum number of hits that can be expected will be proportional to that. If it's possible to set the value automatically, possibly even repeating the search automatically if it was set too low, we could get rid of a parameter the users won't comprehend anyway.

Change History (2)

comment:1 Changed 13 years ago by westram

IMO a less good idea. The limit is only there to protect users with "smaller" machines. We only can decide whether we want to protect them or not.

If we don't want, we can simply change the default for AWAR_PD_MATCH_MAX_RES​ to 0 and the limit is gone. Detecting it dynamically does nothing better than setting no limit, it just does more work to get the same result.

To help you decide whether such a limit is useful or not,

  • open up silva-ref
  • build ptserver
  • match 'NNNNNN' with
    • 'Accepted N-matches' = 6
    • 'N-match limit' = 7
    • 'Max. results' = 0

How long does it take to display results?

Do you think we need some kind of protection? :)

comment:2 Changed 9 years ago by westram

  • Resolution set to wontfix
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.