Opened 12 years ago

Closed 8 years ago

#274 closed defect (discarded)

fix mnemonic handling

Reported by: epruesse Owned by: devel
Priority: minor Milestone:
Component: Library (GUI) Version: gtkport
Keywords: Cc:

Description (last modified by westram)

  • implement mnemonic check for GUI elements of a window (check vs. duplicates etc.)
  • provide a way to define mnemonics for GDE GUI elements (buttons, radio buttons, …)
    • currently several GDE-elements define '1' as mnemonic (hardcoded somewhere?)
  • provide a way to define mnemonics in user masks
  • activating GUI elements like testfields or optionsmenus is not possible. Could it be made possible by assigning a mnemonic to the attached label (or to the most-recently used label)?

related: #438

Change History (12)

comment:1 Changed 11 years ago by epruesse

  • Milestone set to gtkmerge

comment:2 Changed 11 years ago by epruesse

  • Status changed from new to assigned

comment:3 Changed 11 years ago by westram

If this ticket talks about 'global key definition' (as opposed to 'mnemonics' as e.g. used in #438) - can you change the summary?

comment:4 Changed 11 years ago by epruesse

  • Description modified (diff)

comment:5 Changed 11 years ago by epruesse

I created the ticket, because the way the mnemonics are converted from ARB (char title*, char* letter) to GTK (char* title_w_underscore_before_mnemonic_letter) is still a bit of a hack. I wasn't even sure where to put it.

comment:6 follow-up: Changed 11 years ago by westram

  • Milestone changed from gtkmerge to aftermerge

Ok, I agree we plan to use GTK style ("title_w_underscore_before_mnemonic_letter") in the future. Because that requires changes all over client code, it should be done either in trunk (by removing mnemonic arguments from functions) or aftermerge.

comment:7 Changed 11 years ago by epruesse

I vote for aftermerge. That's the easiest to do.

comment:8 Changed 9 years ago by westram

  • Owner changed from epruesse to westram
  • Status changed from assigned to _started

will fix worst bugs

comment:9 Changed 9 years ago by westram

Fixed problems with labels already containing an '_' [14855].

comment:10 in reply to: ↑ 6 Changed 9 years ago by westram

  • Description modified (diff)
  • Milestone aftermerge deleted
  • Owner changed from westram to devel
  • Priority changed from normal to minor
  • Status changed from _started to new
  • Summary changed from implement mnemonics to fix mnemonic handling

Replying to myself:

Ok, I agree we plan to use GTK style ("title_w_underscore_before_mnemonic_letter") in the future.

I no longer agree on that, for the following reasons:

  • separating displayed text and mnemonic character is much less a hack than escaping a string with underscores (esp. if that string already may contain underscores). Just my POV.
  • moving the responsibility for correct handling of these underscore-escaped strings to client-land is error-prone, esp. when some of these strings are
    • read from config files (e.g. GDE menus; fixed by recent patch),
    • taken from filenames (e.g. user masks; fixed by recent patch),
    • generated in some other programmatical way (e.g. GC-descriptions in calls to AW_manage_GC which end up as labels; fixed by recent patch)
  • by any means duplicated mnemonics should be avoided because they change the way things work. AFAIK gtk has no way of avoiding that, so we should stick with the mnemonic scope checker as implemented in ARB (DEBUG).

comment:11 Changed 9 years ago by westram

  • Description modified (diff)

comment:12 Changed 8 years ago by westram

  • Resolution set to discarded
  • Status changed from new to closed

gtk-port is dead

Note: See TracTickets for help on using tickets.