Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#303 closed defect (fixed)

Detach button in species information window does nothing

Reported by: aboeckma Owned by: devel
Priority: major Milestone:
Component: Library (GUI) Version: gtkport
Keywords: Cc:

Description

  • select species
  • open species information window
  • click detach
  • notice error message on command line
  • notice that nothing else happens

The error message is:

(arb_ntree:4657): GLib-GObject-WARNING **: g_object_set_valist: object class `GtkHBox' has no property named `label'

Change History (5)

comment:1 Changed 11 years ago by westram

  • functionality works properly (only the button label does not change into 'GET')

comment:2 Changed 11 years ago by aboeckma

This bug is caused by the ARB code using internal WINDOW calls. Namely ARB calls AW_window::get_last_widget() which directly returns a GtkWidget?. ARB assumes that the returned widget always has a label which is not always the case.

Proposed bugfix:

  • Remove get_last_widget().
  • Add optional text_awar to buttons. If the awar is present the button displays the text from the awar.
  • Use that awar to change the button text upon detach.

The bugfix requires changes to code outside of WINDOW. Should I do it anyway?

comment:3 Changed 11 years ago by aboeckma

  • Priority changed from normal to major

comment:4 Changed 11 years ago by aboeckma

  • Resolution set to fixed
  • Status changed from new to closed

comment:5 Changed 11 years ago by aboeckma

Fixed by [10283] in gtk_only and by [10281] in trunk

Note: See TracTickets for help on using tickets.