Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#507 closed defect (fixed)

sort by topology does poor job for big versus small tree

Reported by: westram Owned by: westram
Priority: minor Milestone: arb6
Component: Library (other) Version: SVN
Keywords: Cc:

Description (last modified by westram)

When sorting a bigger tree according to a smaller tree (e.g. useful after inserting species into an existing tree to see where they have been dropped) sorting is very poor.

The algorithm assumes a position values of 0.5 for unknown species. Doing that forces unknown species

  • downwards in the upper half and
  • upwards in the lower half.

Instead it should use some magic value (with meaning unknown) only forcing these species towards tree-center if no other information is present.

Pointer:

  • feature has been introduced with #445

Attachments (4)

SourceTree.png (9.2 KB) - added by westram 10 years ago.
AppliedOrderTree.png (3.6 KB) - added by westram 10 years ago.
ResultTree.png (9.1 KB) - added by westram 10 years ago.
FixedTree.png (9.0 KB) - added by westram 10 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 10 years ago by westram

  • Owner changed from devel to westram
  • Status changed from new to _started

Changed 10 years ago by westram

Changed 10 years ago by westram

Changed 10 years ago by westram

comment:2 Changed 10 years ago by westram

Example of misbehavior

When input-tree
is sorted according to the following smaller sort-tree
the result-tree is

Sort order of colored species in result-tree matches their order in sort-tree. so far so good.

Problems (marked species):

  • the subtree containing CloTyro3/4 (and 4 more)
    • gets "random" order, because all species are "unknown" in sort-tree → original order of input-tree should be kept for such subtrees
    • whole subtree is "pulled" downwards, towards the tree-center (swapping position with its brother-subtree containing CloButyr/2)
  • CelBiazo "pulls" upwards, towards the tree-center → should stay below its brother-subtree (as in input-tree, regardless of new order of brother-subtree

Changed 10 years ago by westram

comment:3 Changed 10 years ago by westram

  • Resolution set to fixed
  • Status changed from _started to closed

by [12019]

Fixed result-tree is

comment:4 Changed 10 years ago by westram

  • Description modified (diff)
Note: See TracTickets for help on using tickets.