merge-tool 'transfer species' crashes

[westram]

Reproduce:

• run

  arb_ntree $ARBHOME/demo.arb nosuch.arb
  

• click Tranfer species
• bang

works in motif

Backtrace:

#0  0x00007ffff6ed2992 in AW_selection_list::clear (this=0x0) at AW_select.cxx:210
#1  0x000000000064947f in QUERY::DbQuery_update_list (query=0xdf0720) at db_query.cxx:391
#2  0x0000000000648f67 in first_searchkey_changed_cb (query=0xdf0720) at db_query.cxx:242
#3  0x00000000005a17fe in StrictlyTypedCallback<void, AW_root*, long, long>::operator() (this=0xdf2990, p1=0xa06b80, p2=14616352, p3=0) at /home/ralf/ARB-bilbo/ARB.gtk.test/INCLUDE/cbtypes.h:117
#4  0x00000000005a15ae in Callback_FVV<void, AW_root*>::operator() (this=0xdf2990, fixed=0xa06b80) at /home/ralf/ARB-bilbo/ARB.gtk.test/INCLUDE/cbtypes.h:172
#5  0x00007ffff6ed9e23 in RootCallbackSlot::emit (this=0xdf2980) at AW_signal.cxx:113
#6  0x00007ffff6ed5a18 in AW_signal::emit (this=0xdf0870) at AW_signal.cxx:317
#7  0x00007ffff6e9c4da in AW_awar_impl::run_callbacks (this=0xdf0860) at AW_awar.cxx:160
#8  0x00007ffff6e9fab5 in AW_awar_impl::update (this=0xdf0860) at AW_awar.cxx:640
#9  0x00007ffff6e9fba5 in _aw_awar_gbdata_changed (awar=0xdf0860) at AW_awar.cxx:654
#10 0x00007ffff7ab5b0c in StrictlyTypedCallback<void, GBDATA*, long, GB_CB_TYPE>::operator() (this=0x7fffffffc550, p1=0xde5548, p2=14616672, p3=GB_CB_CHANGED) at /home/ralf/ARB-bilbo/ARB.gtk.test/INCLUDE/cbtypes.h:117
#11 0x00007ffff7ab493b in Callback_FVF<void, GBDATA*, GB_CB_TYPE>::operator() (this=0xdefec0, f1=0xde5548, f2=GB_CB_CHANGED) at /home/ralf/ARB-bilbo/ARB.gtk.test/INCLUDE/cbtypes.h:230
#12 0x00007ffff7ab2192 in TypedDatabaseCallback::operator() (this=0xdefec0, gbd=0xde5548, type_=GB_CB_CHANGED) at gb_cb.h:44
#13 0x00007ffff7ab259b in gb_callback::call (this=0xdefec0, with=0xde5548, typemask=GB_CB_CHANGED) at gb_cb.h:113
#14 0x00007ffff7ab261c in gb_callback_list::call (this=0xdf0a10, with=0xde5548, typemask=GB_CB_CHANGED) at gb_cb.h:132
#15 0x00007ffff7a8023e in gb_do_callbacks (gbd=0xde5548) at arbdb.cxx:1149
#16 0x00007ffff7a80a6f in GB_write_pntr (gbd=0xde5548, s=0xe0a5e0 "----", bytes_size=5, stored_size=4) at arbdb.cxx:1302
#17 0x00007ffff7a80ba9 in GB_write_string (gbd=0xde5548, s=0xe0a5e0 "----") at arbdb.cxx:1336
#18 0x00007ffff7a81158 in GB_write_as_string (gbd=0xde5548, val=0xe0a5e0 "----") at arbdb.cxx:1427
#19 0x00007ffff6e9ea18 in AW_awar_string::write_string (this=0xdf0860, para=0xe0a5e0 "----", do_touch=false) at AW_awar.cxx:517
#20 0x00007ffff6ed15b3 in AW_scalar::write_to (this=0xe0a590, awar=0xdf0860) at AW_scalar.cxx:31
#21 0x00007ffff6ed2b50 in AW_selection_list::select_default (this=0xe06990) at AW_select.cxx:256
#22 0x00007ffff6ed28c6 in AW_selection_list::refresh (this=0xe06990) at AW_select.cxx:195
#23 0x00007ffff6ed2712 in AW_selection_list::update (this=0xe06990) at AW_select.cxx:168
#24 0x00007ffff6ed2943 in AW_selection::refresh (this=0xe0a440) at AW_select.cxx:206
#25 0x000000000066e26a in create_selection_list_on_itemfields (gb_main=0xbd6200, aws=0xb90170, varname=0xdf05f0 "tmp/dbquery_db2/key_0", type_filter=6236, scan_xfig_label=0x0, rescan_xfig_label=0x7253dd "rescan2", selector=..., columns=22, visible_rows=20, field_filter=SF_PSEUDO, popup_button_id=0xe08610 "field_sel_db2_0") at item_sel_list.cxx:170
#26 0x00000000006535cd in QUERY::create_query_box (aws=0xb90170, awtqs=0x7fffffffcde0, query_id=0x725438 "db2") at db_query.cxx:2693
... [rest skipped]

[westram]

[12403] again shows above backtrace

[westram]

[12406] fixes assertion failure

TODO

• field-selections of "right" search-tool dropped back to default (showing "nothing"). Should be "name"

[westram]

• field-selections of "right" search-tool dropped back to default (showing "nothing"). Should be "name"

• displaying 'nothing' is not really wrong (destination does not exist and has no fields @ all)
• should at least display '<no field>' instead of being empty
  • this indicates an update problem in fallback to default!
• might be confusing for : after transferring some species, clicking right 'Search' results in

  17:03.11  Failed to query 'ArtGlobi'.
            (Reason: ARB ERROR: Invalid char '-' in key '----')
  

Maybe it would be better to skip field fallback for destination query-box? Or use '[any field]' as default!

[westram]

• should at least display '<no field>' instead of being empty
  • this indicates an update problem in fallback to default!

fixed by [12407]. Now displays '<no field>'.

[westram]

Or use '[any field]' as default!

implemented by [12408]

[westram]

Milestone powerusability deleted