editor crashes if no SAI selected for column stat

[westram]

Reproduce:

• arb_edit4 demo.arb
• View/Activate column stat
• select no column stat
• click go

Note: May have worked in earlier arb-versions (compare code here​).

Possible solutions:

• disallow activation w/o SAI or
• fake rates (ie. use even rates). would that make any sense?

[westram]

backtrace:

#0  0x000000000060479f in ST_ML::get_rate_at (this=0xa82860, pos=0) at st_ml.hxx:214
#1  0x00000000005ffa6f in MostLikelySeq::calculate_ancestor (this=0xc9a820, lefts=0xc9a880, leftl=0.017241399735212326, rights=0xc9a9e0, rightl=0.017241399735212326) at ST_ml.cxx:270
#2  0x00000000006014a5 in ST_ML::get_mostlikely_sequence (this=0xa82860, node=0xc22860) at ST_ml.cxx:653
[...]
#16 0x000000000060146c in ST_ML::get_mostlikely_sequence (this=0xa82860, node=0xc210a0) at ST_ml.cxx:651
#17 0x000000000060180d in ST_ML::get_ml_vectors (this=0xa82860, species_name=0x0, node=0xc21200, start_ali_pos=0, end_ali_pos=175) at ST_ml.cxx:717
#18 0x0000000000601eb8 in ST_ML::get_color_string (this=0xa82860, species_name=0x0, node=0xc21200, start_ali_pos=0, end_ali_pos=175) at ST_ml.cxx:830
#19 0x0000000000602873 in STAT_get_color_string (st_ml=0xa82860, species_name=0x0, node=0xc21200, start_ali_pos=4, end_ali_pos=163) at ST_window.cxx:108
#20 0x0000000000507dd1 in ED4_sequence_terminal::draw (this=0xc4c8e0) at ED4_text_terminals.cxx:434
#21 0x00000000005089ea in ED4_text_terminal::Show (this=0xc4c8e0, refresh_all=0, is_cleared=0) at ED4_text_terminals.cxx:605
#22 0x00000000004d46c9 in ED4_manager::Show (this=0xc4c600, refresh_all=0, is_cleared=0) at ED4_manager.cxx:1112
[...]
#30 0x00000000004d46c9 in ED4_manager::Show (this=0xc43fe0, refresh_all=0, is_cleared=0) at ED4_manager.cxx:1112
#31 0x00000000004d3ede in ED4_root_group_manager::Show (this=0xc43fe0, refresh_all=0, is_cleared=0) at ED4_manager.cxx:993
#32 0x00000000004d46c9 in ED4_manager::Show (this=0xc43ef0, refresh_all=0, is_cleared=0) at ED4_manager.cxx:1112
#33 0x00000000004d3c86 in ED4_main_manager::Show (this=0xc43ef0, refresh_all=0, is_cleared=0) at ED4_manager.cxx:944
#34 0x00000000004efeb6 in ED4_root::refresh_window_simple (this=0x9e24a0, redraw=false) at ED4_root.cxx:119
#35 0x00000000004f023e in ED4_root::refresh_all_windows (this=0x9e24a0, redraw=false) at ED4_root.cxx:173
#36 0x00000000004e498d in ED4_timer () at ED4_no_class.cxx:851
#37 0x00007ffff6ee3502 in StrictlyTypedCallback<unsigned int, AW_root*, long, long>::operator() (this=0xc87e80, p1=0x9e2b60, p2=0, p3=0) at /home/ralf/ARB-bilbo/ARB.trunk.test/INCLUDE/cbtypes.h:117
#38 0x00007ffff6ee3366 in Callback_FVV<unsigned int, AW_root*>::operator() (this=0xc87e80, fixed=0x9e2b60) at /home/ralf/ARB-bilbo/ARB.trunk.test/INCLUDE/cbtypes.h:172
#39 0x00007ffff6ee3178 in AW_timer_cb_struct::callOrDelayIfDisabled (this=0xc87e70) at AW_root.cxx:432
#40 0x00007ffff6ee2568 in AW_timer_callback (aw_timer_cb_struct=0xc87e70) at AW_root.cxx:446
#41 0x00007ffff655f1cf in ?? () from /usr/lib/libXt.so.6
#42 0x00007ffff655f30d in XtAppNextEvent () from /usr/lib/libXt.so.6
#43 0x00007ffff65518b3 in XtAppMainLoop () from /usr/lib/libXt.so.6
#44 0x00007ffff6ee2aba in AW_root::main_loop (this=0x9e2b60) at AW_root.cxx:547
#45 0x00000000004d0d7e in ARB_main (argc=1, argv=0x7fffffffe2f0) at ED4_main.cxx:579
#46 0x00000000004ac7ff in main (argc=2, argv=0x7fffffffe2e8) at arb_main.cxx:10

[westram]

move open tickets before release