Opened 10 years ago

Closed 10 years ago

Last modified 3 years ago

#625 closed porting (fixed)

MacPorts fails to install sativa directory in bin

Reported by: mcottrell Owned by: akozlov
Priority: normal Milestone: arb7.0
Component: no idea Version:
Keywords: MacPorts Cc: alexei.kozlow@…

Description

The new sativa directory that appears in the bin directory is causing problems for MacPorts?. Would it be possible to simply place all the sativa python stuff directly in the bin directory? That would make MacPorts? a lot easier.

Change History (14)

comment:1 in reply to: ↑ description Changed 10 years ago by westram

  • Cc alexei.kozlow@… added

Replying to mcottrell:

The new sativa directory that appears in the bin directory is causing problems for MacPorts?.

What kind of problems?

comment:2 Changed 10 years ago by mcottrell

MacPorts? halts with an error when it tries to move the sativa folder into /opt/local/bin where MacPorts? keeps all the binaries. In MacPorts? a temporary workspace is used to build everything and the final step is moving things into their proper place under the MacPorts? $prefix (defaults is /opt).

comment:3 in reply to: ↑ description ; follow-up: Changed 10 years ago by akozlov

Replying to mcottrell:

Would it be possible to simply place all the sativa python stuff directly in the bin directory? That would make MacPorts? a lot easier.

It would create quite a mess, since there is also an underlying directory structure in sativa (e.g. a bunch of python modules under sativa/epac). In my view, the best solution would be to move the whole thing out of bin and then just symlink the top-level scripts to there - like you did for some SH and Perl scripts.

comment:4 in reply to: ↑ 3 Changed 10 years ago by westram

Replying to akozlov:

In my view, the best solution would be to move the whole thing out of bin and then just symlink the top-level scripts to there - like you did for some SH and Perl scripts.

I would prefer that as well. There was already a patch necessary to handle sativa installation: [13065]

One simple way would be to move the sativa-code (that is needed in distribution) into $ARBHOME/lib/sativa (directly inside SVN), instead of maintaining it below $ARBHOME/GDE/SATIVA and then copying it around.

comment:5 follow-up: Changed 10 years ago by akozlov

I like $ARBHOME/lib/sativa as a final location, but do you think copying in there could also cause problems? Since it'd be nice to keep the original installation together in $ARBHOME/GDE/SATIVA and then scatter the files to corresponding locations during ARB build (apart of python scripts, there are also menu file, RAxML binaries, perl wrapper etc.). This approach seems to work for other tools, e.g. MAFFT.

comment:6 in reply to: ↑ 5 Changed 10 years ago by westram

Replying to akozlov:

I like $ARBHOME/lib/sativa as a final location, but do you think copying in there could also cause problems?

No. Just handle it as you prefer :)

comment:7 Changed 10 years ago by westram

  • Owner changed from devel to akozlov
  • Status changed from new to assigned

comment:8 Changed 10 years ago by akozlov

OK thanks, then I'll fix it like this and commit to trunk.

comment:9 Changed 10 years ago by akozlov

This should be now fixed in trunk with [13203]. Could you please test?

comment:10 Changed 10 years ago by mcottrell

Good work. arb trunk/13203 now builds and runs in MacPorts?.

Now I'm curious, what new functionality does sativa add to arb?

Thanks, Matt

comment:11 Changed 10 years ago by westram

  • Resolution set to fixed
  • Status changed from assigned to closed

comment:12 Changed 10 years ago by akozlov

Great!

SATIVA stands for Semi-Automatic Taxonomy Improvement and Validation Algorithm. In short, it employs RAxML to find incongruence between the taxonomy and the phylogenetic tree, and suggests sequences/taxa with putatively wrong taxonomic annotations.

We're now preparing a manuscript that describes this approach (joined work with Pelin Yilmaz from MPI Bremen).

Alexey

comment:13 Changed 9 years ago by westram

  • Milestone set to arb6.1

mark changes that got fixed after arb 6.0.x

comment:14 Changed 3 years ago by westram

  • Milestone changed from arb6.1 to arb7.0

Milestone renamed

Note: See TracTickets for help on using tickets.