Opened 6 months ago

Last modified 9 days ago

#857 accepted defect

Rejection of numeric groupnames aborts probably expensive calculations

Reported by: westram Owned by: westram
Priority: major Milestone:
Component: Library (DB) Version: SVN
Keywords: Cc:

Description (last modified by westram)

Reproduce:

  • use a tree containing numeric groupnames (e.g. the tree that comes with SILVA_138.1_SSURef_NR99_12_06_20_opt.arb)
  • mark some species that are in the tree
  • call Tree/Remove species from tree/Remove marked.
    This will pop up the following message:
    11:32.39  Invalid group name '661256' (would be misinterpreted as plain inner node with a support value of 66% if re-imported from newick file)
    
    The marked species seem to be removed from tree.
  • Now call Tree/Tree admin, then select << none >> and after that, again select the existing tree
    ⇒ all removed species re-appear!

Warning: If you encounter the above error message, you should fix these group names ASAP!

All operations modifying trees will be aborted, i.e. have no effect, as long as such groups exist.

Proposed fix:

If such a group exists, do not abort with an error under all conditions:

  • attempts to save a newick tree shall refuse to do so (report error).
  • saving a tree after ARB-Parsimony/quick-add shall save the tree with bad groups (just warn).

related: #832
introduced by: [19282]

Change History (3)

comment:1 Changed 6 months ago by westram

  • Component changed from no idea to Library (DB)
  • Owner changed from devel to westram
  • Priority changed from normal to major
  • Status changed from new to accepted
  • Version set to SVN

comment:2 Changed 6 months ago by westram

  • Description modified (diff)

comment:3 Changed 9 days ago by westram

Also reported by #862

Note: See TracTickets for help on using tickets.