Opened 17 years ago

Closed 14 years ago

#106 closed task (fixed)

positions and ecoli position differ by one for sequence editor and probe match result

Reported by: meierh Owned by: devel
Priority: normal Milestone:
Component: no idea Version: SVN
Keywords: probe match, sequence editor, pos, ecoli Cc:

Description

positions and ecoli position differ by one for sequence editor and probe match result, i.e.

sequence editor: pos 1007, ecoli 8

probe match: pos 1006, ecoli 7

Attachments (1)

SAI misaligned.gif (107.5 KB) - added by westram 16 years ago.
misalignment in 'Match SAI'

Download all attachments as: .zip

Change History (7)

comment:1 Changed 16 years ago by meierh

  • Owner changed from devel to meierh
  • Status changed from new to assigned

confirmed for SVN 5990 on Opensuse 10.3 64-bit

comment:2 Changed 16 years ago by westram

  • Owner changed from meierh to devel
  • Priority changed from major to normal
  • Status changed from assigned to new
  • Type changed from defect to task
  • positions in editor are correct (first position is 1).
  • positions in probe match are not wrong (they just start counting with position 0).

The results in probe match are shown as generated by pt-server

  • changing the pt-server-result has wide consequences, so this is no option
  • need to change the way the match results are displayed
    • there are 2 classes ProbeMatchParser? and ParsedProbeMatch? to handle probe-match-results, might be useful.
    • think about a way to forward alignment position to editor (when selecting a match result).

comment:3 Changed 16 years ago by eissler

  • Resolution set to fixed
  • Status changed from new to closed

probe match is now showing the same position as the editor (svn-version 6000)

(note: only the displaying was changed, so the count is still starting at position 0)

  • tested on Ubuntu 9.04 64bit

comment:4 Changed 16 years ago by westram

  • Priority changed from normal to blocker
  • Resolution fixed deleted
  • Status changed from closed to reopened

  • patch [6000] was no good idea for several reasons
    • the "displaying" is the ONLY output of the pt-server used by ARB_NTREE. By changing it, you broke all parts using ProbeMatchParser?, which parses the output you changed.
    • there are still some parts not even using ProbeMatchParser?
      • e.g. Sonde::get_matching_species() does some parsing on that output
      • probe library also used probe match
    • ptpan uses the same output, now pt-server and ptpan are out-of-sync
    • All position-dependent member functions of ProbeMatchParser? and ParsedProbeMatch? now report wrong position (1…) - they are expected to report (0..). Any dependent code works wrong now (e.g. 'Match SAI' in probe match displays SAIs at the wrong position)

Changed 16 years ago by westram

misalignment in 'Match SAI'

comment:5 Changed 16 years ago by eissler

  • Priority changed from blocker to normal

revoked changes from patch 6000.

comment:6 Changed 14 years ago by westram

  • Resolution set to fixed
  • Status changed from reopened to closed

fixed by [7258]

Note: See TracTickets for help on using tickets.