Non-existing socket connection lets arb programs crash

[baderk]

Connecting to a non-existing socket, e.g. "arb_ntree localhost:1234" or "arb_edit4 localhost:2345" causes ARB programs to crash instead of reporting an error message / GB_ERROR.

SVN Rev. 6666

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff7b0e158 in gbcmc_key_alloc (gbd=0x7d2ff0, key=0x7ffff7b5fdc5 "__SYSTEM__") at adcomm.cxx:1762
1762        socket = Main->c_link->socket;
(gdb) bt
#0  0x00007ffff7b0e158 in gbcmc_key_alloc (gbd=0x7d2ff0, key=0x7ffff7b5fdc5 "__SYSTEM__") at adcomm.cxx:1762
#1  0x00007ffff7b3957b in gb_create_key (Main=0x7c1b00, s=0x7ffff7b5fdc5 "__SYSTEM__", create_gb_key=true) at ad_core.cxx:743
#2  0x00007ffff7b312c0 in GB_key_2_quark (gbd=0x7d2ff0, s=0x7ffff7b5fdc5 "__SYSTEM__") at arbdb.cxx:1214
#3  0x00007ffff7b389cf in gb_delete_main_entry (gb_main_ptr=0x7fffffffded0) at ad_core.cxx:523
#4  0x00007ffff7b38cd2 in gb_delete_dummy_father (dummy_father=0x7c1b20) at ad_core.cxx:552
#5  0x00007ffff7b055e0 in GB_login (cpath=0x7fffffffe506 "localhost:1234", opent=0x55356c "rwt", user=0x7fffffffe737 "kai") at ad_load.cxx:1641
#6  0x00007ffff7b05725 in GB_open (path=0x7fffffffe506 "localhost:1234", opent=0x55356c "rwt") at ad_load.cxx:1674
#7  0x00000000004707d8 in main (argc=1, argv=0x7fffffffe1f0) at ED4_main.cxx:526
(gdb) 

[westram]

works now:

(gdb) run localhost:1234
[...]
arb_ntree: Error: ARB ERROR: There is no ARBDB server 'localhost:1234', please start one or add a filename
[Inferior 1 (process 19731) exited with code 01]

(gdb) run localhost:2345
Starting program: /home/ralf/ARB-bilbo/ARB.trunk.NDEBUG/bin/arb_edit4 localhost:2345
Using 'default_configuration'
Using properties from '/home/ralf/ARB-bilbo/ARB.trunk.NDEBUG/lib/arb_default/status.arb'
arb_edit4: Error: ARB ERROR: There is no ARBDB server 'localhost:2345', please start one or add a filename
[Inferior 1 (process 19753) exited normally]