Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#538 closed misbehavior (fixed)

exiting arb_ntree with EXIT_FAILURE causes ARB crash message

Reported by: epruesse Owned by: westram
Priority: normal Milestone: arb6
Component: no idea Version: SVN
Keywords: Cc:

Description

I'm pretty sure we don't want to tell the user that this is a crash. :)

epruesse@arb-server-3:~$ arb
ARB is started here
Using ARBHOME='/arb/software/arb_ubuntu_1004/latest'
Using properties from /home/epruesse/.arb_prop
Please wait while the program ARB is starting .....
Waiting for '/home/epruesse/.arb_tmp/sockets/arb_launcher.11179'..
[arb_launcher[0]: Starting 'arb_ntree'..]
Using properties from '/home/epruesse/.arb_prop/ntree.arb'
Using properties from '/arb/software/settings/global/arb_default/status.arb'
Error: Can't open display: :0
Error: Can't open display: :0
ARB: Loading 'ntree.arb'
ARB: Loading '/home/epruesse/.arb_prop/ntree.arb' done

[arb_launcher[0]: 'arb_ntree' has terminated with error]
[arb_launcher[0]: Still have 1 arb processes..]
[arb_launcher[0]: All launched processes terminated]

Session log has been stored in /home/epruesse/.arb_prop/logs/session.20140514_181756.11189.tgz
    and is also accessible via /home/epruesse/ARB_last_session.tgz

ARB crashed :-(
To report this goto http://bugs.arb-home.de/wiki/BugReport
Please include the session log mentioned above

Change History (9)

comment:1 in reply to: ↑ description Changed 11 years ago by westram

Replying to epruesse:

I'm pretty sure we don't want to tell the user that this is a crash. :)

What else? That ARB needed to terminate?

comment:2 follow-up: Changed 11 years ago by epruesse

It's just that the last three lines "ARB crashed :-(" prompting the user to file a bug report seem wrong. It happened to me and I was wondering for a few seconds why the hell ARB had crashed, when it was just the X11 forwarding in SSH that didn't work.

No Display no ARB. Not ARB's fault, not a crash.

Anyway, resolve as won't fix if you think it's not important enough. I'm not sure how to handle this anyway.

comment:3 in reply to: ↑ 2 Changed 11 years ago by westram

  • Status changed from new to infoneeded_new

Replying to epruesse:

No Display no ARB. Not ARB's fault, not a crash.

Ok.. ACK

I'm not sure how to handle this anyway.

If somebody knows a way how to detect that X-display is unavailable, we'll fix it.

comment:4 Changed 11 years ago by westram

  • Milestone set to arb6
  • Status changed from infoneeded_new to new
  • Summary changed from having no X11 display causes ARB crash message to exiting arb_ntree with EXIT_FAILURE causes ARB crash message
  • Version set to SVN

seems to be a general problem:

> arb --lol                                                             [11:52]
Using ARBHOME='/home/ralf/ARB-bilbo/ARB.trunk.test'
Using properties from /home/ralf/.arb_prop
Please wait while the program ARB is starting .....
Waiting for '/home/ralf/.arb_tmp/sockets/arb_launcher.1511'..
[arb_launcher[0]: Starting 'arb_ntree --lol'..]
Using properties from '/home/ralf/.arb_prop/ntree.arb'
Using properties from '/home/ralf/ARB-bilbo/ARB.trunk.test/lib/arb_default/status.arb'
arb_ntree: Error: Unknown switch '--lol'
ARB: Loading 'ntree.arb'
ARB: Loading '/home/ralf/.arb_prop/ntree.arb' done

[arb_launcher[0]: 'arb_ntree --lol' has terminated with error]
[arb_launcher[0]: Still have 1 arb processes..]
[arb_launcher[0]: All launched processes terminated]

Session log has been stored in /home/ralf/.arb_prop/logs/session.20140517_115429.1521.tgz
    and is also accessible via /home/ralf/ARB_last_session.tgz

ARB crashed :-(
To report this goto http://bugs.arb-home.de/wiki/BugReport
Please include the session log mentioned above

[press ENTER]

comment:5 Changed 11 years ago by westram

  • Owner changed from devel to westram
  • Status changed from new to _started

comment:6 follow-up: Changed 11 years ago by epruesse

How about using the exit codes that bash uses? 128+signo to indicate abort by signal. That way arb_launcher can tell.

comment:7 in reply to: ↑ 6 Changed 11 years ago by westram

Replying to epruesse:

How about using the exit codes that bash uses? 128+signo to indicate abort by signal. That way arb_launcher can tell.

arb catches some sigs - need to add them into exitcode

comment:8 Changed 11 years ago by westram

  • Resolution set to fixed
  • Status changed from _started to closed

comment:9 Changed 11 years ago by westram

[12276] does

> arb demo.arb
Using ARBHOME='/home/ralf/ARB-bilbo/ARB.trunk.test.NDEBUG'
Using properties from /home/ralf/.arb_prop
Please wait while the program ARB is starting .....
Waiting for '/home/ralf/.arb_tmp/sockets/arb_launcher.1344'..
[arb_launcher[0]: Starting 'arb_ntree demo.arb'..]
Using properties from '/home/ralf/.arb_prop/ntree.arb'
Using properties from '/home/ralf/ARB-bilbo/ARB.trunk.test.NDEBUG/lib/arb_default/status.arb'
Error: Can't open display: bla
Error: Can't open display: bla
ARB: Loading 'ntree.arb'
ARB: Loading '/home/ralf/.arb_prop/ntree.arb' done

[arb_launcher[0]: 'arb_ntree demo.arb' has terminated with error 1]
[arb_launcher[0]: Still have 1 arb processes..]
[arb_launcher[0]: All launched processes terminated]

Session log has been stored in /home/ralf/.arb_prop/logs/session.20140517_165511.1354.tgz
    and is also accessible via /home/ralf/ARB_last_session.tgz
> 
Note: See TracTickets for help on using tickets.