Opened 11 years ago

Closed 11 years ago

Last modified 9 years ago

#537 closed defect (fixed)

fix selection list fallback problems

Reported by: westram Owned by: westram
Priority: normal Milestone:
Component: no idea Version: gtkport
Keywords: Cc:

Description (last modified by westram)

Releated tickets:

Todo:

  • Search next neighbours of Selected fails with Select a species first. Selected species is instantly deselected by selection list(?) fixed by [12231]
  • EDIT4/Save configuration as silently does NOT save (omg) fixed with [12255]

Remaining issues:

  • if an awar used for selection list is written to elsewhere (e.g. from a callback), the selection list will instantly undo the changes
    • can't think of a way to automatically detect such situations
    • one case is known atm: #534

Attachments (3)

nns_failure.amc​ (924 bytes) - added by westram 11 years ago.
demonstrate failure of next neighbour search (with demo.arb)
SaveConfig_doesnt_save.amc​ (675 bytes) - added by westram 11 years ago.
sellist_fallback_fix.patch​ (6.4 KB) - added by westram 11 years ago.
update

Download all attachments as: .zip

Change History (18)

comment:1 Changed 11 years ago by westram

  • Owner changed from devel to westram
  • Status changed from new to _started

Changed 11 years ago by westram

demonstrate failure of next neighbour search (with demo.arb)

comment:2 Changed 11 years ago by westram

  • Description modified (diff)

comment:3 follow-up: Changed 11 years ago by westram

status [12232]: ARB_NT passes callallcallbacks with above patch applied (doesn't mean no problems remain; e.g. #534 is not detected by patch)

comment:4 in reply to: ↑ 3 ; follow-up: Changed 11 years ago by westram

status [12232]: callallcallbacks with above patch applied passes in

  • ARB_NTREE (6 x !run_all_cbs_alph)
  • ARB_DIST (5 x !run_all_cbs_alph)
  • ARB_PARS (5 x !run_all_cbs_alph)
  • ARB_PHYLO (3 x !run_all_cbs_alph)

comment:5 Changed 11 years ago by westram

  • Description modified (diff)

Changed 11 years ago by westram

comment:6 in reply to: ↑ description ; follow-up: Changed 11 years ago by westram

  • EDIT4/Save configuration as silently does NOT save (omg)

run demo.arb with this macro​:

  • motif creates config 'bla'
  • gtk doesn't

comment:7 follow-up: Changed 11 years ago by westram

Window mentioned in #524 is affected by fallback as well. Cannot be tested due to missing buttons.

comment:8 in reply to: ↑ 7 ; follow-up: Changed 11 years ago by westram

Window mentioned in #524 is affected by fallback as well.

  • entering a new name and
    • instantly pressing 'Ok' works
    • pressing TAB lets the entered name disappear (if some existing config was selected before)

comment:9 follow-up: Changed 11 years ago by westram

ARB_EDIT4/Block/Modify SAI:

  • silently does nothing in gtk-version when user modifies a predefined or enters a new ACI/SRT.
  • caused by fallback to default (""; added by StorableSelectionList::load)

comment:10 in reply to: ↑ 6 Changed 11 years ago by westram

  • EDIT4/Save configuration as silently does NOT save (omg)

fixed by [12252]

comment:11 in reply to: ↑ 8 Changed 11 years ago by westram

Window mentioned in #524 is affected by fallback as well.

some issues fixed with [12253]

comment:12 in reply to: ↑ 9 Changed 11 years ago by westram

  • Milestone set to powerusability

ARB_EDIT4/Block/Modify SAI:

  • silently does nothing in gtk-version when user modifies a predefined or enters a new ACI/SRT.

fixed by [12254]

comment:13 in reply to: ↑ 4 Changed 11 years ago by westram

  • Description modified (diff)

status [12255]: callallcallbacks with above patch applied passes in

  • ARB_EDIT4 (6 x !run_all_cbs_alph)

⇒ Nothing left to detect automatically :(

Changed 11 years ago by westram

update

comment:14 Changed 11 years ago by westram

  • Resolution set to fixed
  • Status changed from _started to closed

rest needs to be found by using arb

comment:15 Changed 9 years ago by westram

  • Milestone powerusability deleted

Milestone powerusability deleted

Note: See TracTickets for help on using tickets.