Opened 11 years ago

Closed 11 years ago

Last modified 9 years ago

#520 closed defect (fixed)

'SAI/Create SAI using.../Max. frequency' broken

Reported by: westram Owned by: westram
Priority: major Milestone:
Component: Library (GUI) Version: gtkport
Keywords: Cc:

Description (last modified by westram)

Reproduce:

  • start demo.arb
  • select 'SAI/Create SAI using…/Max. frequency'
  • enter "MAX_FREQUENCY" into input field (contains "none" in gtk, already contains "MAX_FREQUENCY" in motif)
  • click "GO"

⇒ gtk-version creates an SAI called "none" (triggers problems described in #519). motif creates SAI "MAX_FREQUENCY" as expected.

This is a general problem:
gtk writes back the default value when some unknown value is written to an awar used in a selection list. This behavior does not comply with using an AWAR for a selection list and an input field (as done in the example above), i.e. providing some defaults in a list, while allowing the user to enter a custom value.

Related tickets:

Change History (8)

comment:1 Changed 11 years ago by westram

Same in 'SAI/Create SAI using…/Consensus'

comment:2 Changed 11 years ago by westram

  • Owner changed from devel to westram
  • Status changed from new to accepted

comment:3 Changed 11 years ago by epruesse

The "default" value in selection lists is a bit of a broken API, IMO.

I don't have the details present right now, but I do remember that it took quite a few iterations to get this even half-way working. Different parts of ARB seem to expect idiosyncratic behavior of the old implementation.

Feel free to have a go at it, just be aware that things might break elsewhere if you change just about anything. Maybe you'll get it right. :)

Personally, I'm in favor of creating a new "table" API that is more well defined in its behavior and fixing broken situations by moving to that. It's probably post-merge though.

comment:4 Changed 11 years ago by westram

I just try to track down problematic cases and then use select_default_on_awar_mismatch(false); there

comment:5 Changed 11 years ago by westram

  • Status changed from accepted to _started

comment:6 Changed 11 years ago by westram

  • Description modified (diff)

comment:7 Changed 11 years ago by westram

  • Resolution set to fixed
  • Status changed from _started to closed

by [12189] / [12190]

Solution: all creators of selection lists need to decide whether to use fallback2default or not

comment:8 Changed 9 years ago by westram

  • Milestone powerusability deleted

Milestone powerusability deleted

Note: See TracTickets for help on using tickets.