LINK_STATIC_LIBS="ld -r" apparently "misguided"

[epruesse]

ARB fails to build under Debian Sid / Ubuntu 14.10 due to changes in binutils. Apparently the problem is cause by our use of "ld -r":

Subject: ld -r link issues
Date: Mon, 13 Oct 2014 20:18:25 +0200
From: Matthias Klose <doko@debian.org>
To: 763228@bugs.debian.org, arb@packages.debian.org, 764573@bugs.debian.org

the PR ld/17647 issue is now fixed upstream, however upstream recommends not
using ld -r to create these "archives".

"This doesn't look easy to fix.  I'm very tempted to say that people
who use ld -r to package object files deserve to suffer for their
misguided actions..  The underlying problem, with the potential for
nasty exception handling bugs at runtime, has been there since
https://sourceware.org/ml/binutils/2003-02/msg00471.html"

Please address this upstream.

Suggested fix: use "ar rcs" instead.

[westram]

will apply my former patch (solving it with ​branch makefix seems too committed)

[westram]

by log:trunk@14038:14041

[westram]

Please note:
Updating old WCs and just calling 'make all' will fail with

ar: client.a: File format not recognized

or similar.

Fix that by calling 'make relink' (or 'make clean').

[westram]

Milestone renamed