several unittests fail in NDEBUG version compiled with gcc 4.8.0

[westram]

failing tests (log:trunk@13040):

• SEQIO
  • TEST_sequence_export

    Different lines:
    -ID   MetMazei   rna; 66 BP.
    +ID   MetMazei   rna; 16830 BP.
    -FT   source          1..66
    +FT   source          1..16830
    -SQ   Sequence 66 BP;
    +SQ   Sequence 16830 BP;
    
    ARB_textfiles_have_difflines(impexp/embl.eft.exported, impexp/exported) fails: files differ in 3 lines (expected=0)
    SL/SEQIO/seq_export.cxx:796:  Error: Failed expectation 'that(arb_test::textfiles_have_difflines_ignoreDates(expected,outname, 0)).is_equal_to(true)'
    expectation fails because
      'arb_test::textfiles_have_difflines_ignoreDates(expected,outname, 0)' doesnt equal 'true', where
        'arb_test::textfiles_have_difflines_ignoreDates(expected,outname, 0)' is false, and
        'true'                                                                is true
    

• ARBDB
  • TEST_GB_command_interpreter

    ARBDB/adquery.cxx:1195:  Error: Failed expectation 'that(result).is_equal_to("2,3,4")'
    expectation fails because
      'result' doesnt equal '"2,3,4"', where
        'result'  is "510,765,1020", and
        '"2,3,4"' is "2,3,4"
    

• PROBE
  • Note: the following two failures look like a in unittester ("doesnt equal 'true'", but both conditions listed as "true")
  • TEST_MarkedPrefixes

    PROBE/PT_buildtree.cxx:711:  Error: Failed expectation 'that(mp1.isMarked(Compressed("C").seq())).is_equal_to(true)'
    expectation fails because
      'mp1.isMarked(Compressed("C").seq())' doesnt equal 'true', where
        'mp1.isMarked(Compressed("C").seq())' is true, and
        'true'                                is true
    

  • TEST_Partition

    PROBE/PT_buildtree.cxx:774:  Error: Failed expectation 'that(P13.contains(Compressed(".").seq())).is_equal_to(true)'
    expectation fails because
      'P13.contains(Compressed(".").seq())' doesnt equal 'true', where
        'P13.contains(Compressed(".").seq())' is true, and
        'true'                                is true
    

Notes:

• ok in DEBUG version
• ok with gcc 4.8.1, 4.8.3, 4.9.0, 4.9.1
• tested ok on jenkins for gcc 4.4.3, 4.4.7, 4.6.3, 4.7.2, 4.7.3, 4.8.2

Solutions:

• either forbid gcc 4.8.0 (might be broken)
• or fix (undefined?) behavior

[westram]

Replying to westram:

failing tests (log:trunk@13040):

• SEQIO
• ARBDB

• ok in [11079]; broken by [11080]
  • diff:trunk@11079:11080

• PROBE

• tests introduced by [11060]
• in ptsfix
  • ok in [9119]; broken by [9121]
    • diff:branches/ptsfix@9119:9121

[westram]

by [13041:13042]

[westram]

other fix [13044]

• reverts previous workarounds
• forbids gcc 4.8.0 for ARB

[westram]

mark changes that got fixed after arb 6.0.x

[westram]

Milestone renamed